Fix GeoPandas dataset compatibility for naturalearth_cities #5420
+32
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 15, 2025 18:53
Update documentation examples to work with both GeoPandas < 1.0 and >= 1.0. The old gpd.datasets.get_path() method was removed in GeoPandas 1.0. This fix: - Tries the old method first (for backward compatibility) - Falls back to geodatasets package for GeoPandas >= 1.0 - Includes a URL fallback if geodatasets is not available Fixes plotly#4778
…DataFrame\n\nRemoves URL fallback to prevent CI build failures in restricted environments.\nKeeps compatibility with GeoPandas <1.0 and >=1.0, and avoids extra deps.
Contributor
|
Thanks for the PR! We'll try to review this as we have time. This seems to be related to #4782. |
LiamConnors
reviewed
Nov 20, 2025
Member
LiamConnors
left a comment
LiamConnors
left a comment
There was a problem hiding this comment.
Thanks for the PR! I have added a few comments. Let me know if you have any questions.
Comment on lines
+84
to
+85
| import geodatasets | ||
| geo_df = gpd.read_file(geodatasets.get_path('naturalearth.cities')) |
Member
There was a problem hiding this comment.
This dataset doesn't currently exist on geodatasets, so this will never be successful even with geopandas >=1.0
Comment on lines
+60
to
+74
| try: | ||
| # Try the old method (GeoPandas < 1.0) | ||
| geo_df = gpd.read_file(gpd.datasets.get_path('naturalearth_cities')) | ||
| except (AttributeError, ValueError): | ||
| # Use the new method (GeoPandas >= 1.0) | ||
| try: | ||
| import geodatasets | ||
| geo_df = gpd.read_file(geodatasets.get_path('naturalearth.cities')) | ||
| except ImportError: | ||
| # Fallback: build a tiny in-memory GeoDataFrame (no internet or extra deps) | ||
| from shapely.geometry import Point | ||
| geo_df = gpd.GeoDataFrame( | ||
| {"name": ["City A", "City B"], "geometry": [Point(0, 0), Point(10, 10)]}, | ||
| crs="EPSG:4326", | ||
| ) |
Member
There was a problem hiding this comment.
As 'naturalearth.cities' does not exist on geodatasets, I think the best thing to do here would be to have just the example of the dataframe created using GeoDataFrame, like you show in the except block, but with some real cities.
So something like
import plotly.express as px
import geopandas as gpd
from shapely.geometry import Point
geo_df = gpd.GeoDataFrame({
'name': ['London', 'Paris', 'Berlin', 'Madrid', 'Rome'],
'geometry': [
Point(-0.13, 51.51),
Point(2.35, 48.86),
Point(13.41, 52.52),
Point(-3.70, 40.42),
Point(12.50, 41.90),
]
}, crs="EPSG:4326")
fig = px.scatter_map(geo_df,
lat=geo_df.geometry.y,
lon=geo_df.geometry.x,
hover_name="name",
zoom=3)
fig.show()And something similar for the scatter-plots-on-maps example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation examples to support both GeoPandas < 1.0 and >= 1.0.
Context: GeoPandas 1.0 removed the datasets accessor used in
gpd.datasets.get_path("naturalearth_cities").Changes:
geodatasetspackage for GeoPandas >= 1.0geodatasetsis not availableFiles updated:
Docs-only change.